[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 02/13] Add migration capabilites
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v12 02/13] Add migration capabilites |
Date: |
Tue, 19 Jun 2012 10:27:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
On 06/19/2012 09:43 AM, Orit Wasserman wrote:
> Add migration capabiltes that can be queried by the management.
s/capabiltes/capabilities/
> The managment can query the source QEMU and the destination QEMU in order to
s/managment/management/
> verify both support some migration capability (currently only XBZRLE).
> The managment can enable a capabilty for the next migration by using
s/managment/management/
s/capabilty/capability/
> migrate_set_parameter command.
>
> +
> +STEXI
> address@hidden migrate_set_parameter @var{capabilty} @var{state}
s/capabilty/capability/
> address@hidden migrate_set_parameter
> +Enable/Disable the usage of a capability @var{capabilty} for migration.
s/capabilty/capability/
> +##
> +# @migrate_set_parameters
> +#
> +# Set the following migration parameters (like xbzrle )
s/ )/)/
> +Example:
> +
> +-> { "execute": "query-migration-capabilities"}
> +<- { "return": { "xbzrle" }
s/}/} }/
Also, this doesn't match the earlier statement that this would be an
array of MigrationCapabilityInfo, in which case this would be:
{ "return": [ { "capability": "xbzrle", "state": true } ] }
or, someday in the future,
{ "return": [ { "capability": "xbzrle", "state": true },
{ "capability": "foobar", "state": false } ] }
> +Example:
> +
> +-> { "execute": "migrate_set_parameters" , "arguments": { "parameters":
> xbzrle on"} }
Also wrong. Given the syntax, this would be:
{ "execute": "migrate-set-parameters", "arguments":
{ "parameters": [ { "capability": "xbzrle", "state": true } ] } }
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v12 00/13] XBZRLE delta for live migration of large memory app, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 03/13] Add XBZRLE documentation, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 02/13] Add migration capabilites, Orit Wasserman, 2012/06/19
- Re: [Qemu-devel] [PATCH v12 02/13] Add migration capabilites,
Eric Blake <=
- [Qemu-devel] [PATCH v12 05/13] Add uleb encoding/decoding functions, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 04/13] Add cache handling functions, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 06/13] Add save_block_hdr function, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 07/13] Add debugging infrastructure, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 11/13] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/06/19
- [Qemu-devel] [PATCH v12 13/13] Add XBZRLE statistics, Orit Wasserman, 2012/06/19