[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/6] uhci: fix uhci_async_cancel_all
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 6/6] uhci: fix uhci_async_cancel_all |
Date: |
Wed, 20 Jun 2012 16:05:34 +0200 |
We update the QTAILQ in the loop, thus we must use the SAFE version
to make sure we don't touch the queue struct after freeing it.
https://bugzilla.novell.com/show_bug.cgi?id=766310
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/hcd-uhci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c
index 9871e24..2ebce04 100644
--- a/hw/usb/hcd-uhci.c
+++ b/hw/usb/hcd-uhci.c
@@ -292,10 +292,10 @@ static void uhci_async_cancel_device(UHCIState *s,
USBDevice *dev)
static void uhci_async_cancel_all(UHCIState *s)
{
- UHCIQueue *queue;
+ UHCIQueue *queue, *nq;
UHCIAsync *curr, *n;
- QTAILQ_FOREACH(queue, &s->queues, next) {
+ QTAILQ_FOREACH_SAFE(queue, &s->queues, next, nq) {
QTAILQ_FOREACH_SAFE(curr, &queue->asyncs, next, n) {
uhci_async_unlink(curr);
uhci_async_cancel(curr);
--
1.7.1
- [Qemu-devel] [PULL 0/6] usb patch queue., Gerd Hoffmann, 2012/06/20
- [Qemu-devel] [PATCH 6/6] uhci: fix uhci_async_cancel_all,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 4/6] usb-host: attach only to running guest, Gerd Hoffmann, 2012/06/20
- [Qemu-devel] [PATCH 2/6] usb: restore USBDevice->attached on vmload, Gerd Hoffmann, 2012/06/20
- [Qemu-devel] [PATCH 5/6] usb-host: live migration support, Gerd Hoffmann, 2012/06/20
- [Qemu-devel] [PATCH 1/6] ehci: add live migration support, Gerd Hoffmann, 2012/06/20
- [Qemu-devel] [PATCH 3/6] ehci: tracing improvements, Gerd Hoffmann, 2012/06/20
- Re: [Qemu-devel] [PULL 0/6] usb patch queue., Anthony Liguori, 2012/06/26