[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

From: Benjamin Herrenschmidt
Subject: Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()
Date: Thu, 21 Jun 2012 07:30:53 +1000

On Wed, 2012-06-20 at 16:15 -0500, Anthony Liguori wrote:
> On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote:
> > From: David Gibson<address@hidden>
> >
> > This patch adds cpu_physical_memory_set() function.  This is equivalent to
> > calling cpu_physical_memory_write() with a buffer filled with a character,
> > ie, a memset of target memory.
> >
> > It uses a small temporary buffer on the stack.
> >
> > Signed-off-by: David Gibson<address@hidden>
> > Signed-off-by: Benjamin Herrenschmidt<address@hidden>
> Why should this be in the core API?  Shouldn't this be a helper on top of the 

This comes from the original patch which hand implemented the "set" by
reproducing the logic inside cpu_physical_memory_rw(). I turned into a
wrapper on top of the latter based on (your ?) previous reviews on this
list. I don't care enough to argue to keep it if you want it gone, we do
have a "clear" accessors in the PAPR vio dma accessors which is handy
but I could implement it locally.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]