[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions
Date: Thu, 21 Jun 2012 00:40:03 +0300

On Wed, Jun 20, 2012 at 04:16:47PM -0500, Anthony Liguori wrote:
> >diff --git a/qemu-common.h b/qemu-common.h
> >index 8f87e41..80026af 100644
> >--- a/qemu-common.h
> >+++ b/qemu-common.h
> >@@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
> >  typedef struct VirtIODevice VirtIODevice;
> >  typedef struct QEMUSGList QEMUSGList;
> >  typedef struct SHPCDevice SHPCDevice;
> >+typedef struct DMAContext DMAContext;
> Please don't put this in qemu-common.h.  Stick it in a dma-specific header.


The point of typedefs in qemu-common.h is so people can
use type pointer *without pulling in the relevant header*.
If we put a typedef in specific header it defeats the purpose.

It used to even say this somewhere so I don't remember where.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]