[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions
Date: Wed, 20 Jun 2012 17:01:20 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 06/20/2012 04:40 PM, Michael S. Tsirkin wrote:
On Wed, Jun 20, 2012 at 04:16:47PM -0500, Anthony Liguori wrote:
diff --git a/qemu-common.h b/qemu-common.h
index 8f87e41..80026af 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
  typedef struct VirtIODevice VirtIODevice;
  typedef struct QEMUSGList QEMUSGList;
  typedef struct SHPCDevice SHPCDevice;
+typedef struct DMAContext DMAContext;

Please don't put this in qemu-common.h.  Stick it in a dma-specific header.


The point of typedefs in qemu-common.h is so people can
use type pointer *without pulling in the relevant header*.

You're providing a back explanation to something that was completely 

qemu-common.h was created because everything (literally everything) was in a single vl.h.

So qemu-common.h was simply the left over crap from vl.h that didn't have a home elsewhere.

It was never intended that we'd keep adding more stuff to qemu-common.h.


Anthony Liguori

If we put a typedef in specific header it defeats the purpose.

It used to even say this somewhere so I don't remember where.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]