Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

[Blue Swirl]

On Wed, Jun 20, 2012 at 1:56 AM, Guan Xuetao <address@hidden> wrote:
> On Mon, 2012-06-18 at 20:02 +0000, Blue Swirl wrote:
> [snip]
>> > diff --git a/hw/puv3.h b/hw/puv3.h
>> > new file mode 100644
>> > index 0000000..bcfc978
>> > --- /dev/null
>> > +++ b/hw/puv3.h
>> > @@ -0,0 +1,49 @@
>> > +/*
>> > + * Misc PKUnity SoC declarations
>> > + *
>> > + * Copyright (C) 2010-2012 Guan Xuetao
>> > + *
>> > + * This program is free software; you can redistribute it and/or modify
>> > + * it under the terms of the GNU General Public License version 2 as
>> > + * published by the Free Software Foundation, or any later version.
>> > + * See the COPYING file in the top-level directory.
>> > + */
>> > +#ifndef __PUV3_H__
>>
>> Use of leading underscores is reserved to Posix, please use for
>> example HW_PUV3_H.
> Ok, I will change it.
> Perhaps I'm wrong, but IMHO, leading underscores are used pervasively
> for headers protection and low-level definitions.

It's unfortunately common, but as mentioned in HACKING file, those are
reserved to C and POSIX use. For example Linux kernel can disregard
this, because it doesn't use libc and GCC does not exercise the right
to use the reserved prefixes. I guess some people copy this style to
applications where it's no longer correct.

>
> Guan Xuetao
>
>
>