[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] device_tree: load_device_tree
Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] device_tree: load_device_tree(): Allow NULL sizep
Fri, 22 Jun 2012 10:15:55 +0100
On Thu, Jun 21, 2012 at 02:51:24PM +1000, Peter A. G. Crosthwaite wrote:
> The sizep arg is populated with the size of the loaded device tree. Since this
> is one of those informational "please populate" type arguments it should be
> optional. Guarded writes to *sizep against NULL accordingly.
> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
> device_tree.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
Can someone who knows device trees review this?
All current users need the size in order to copy the fdt into guest
memory. Why should the size argument be optional?