[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and u
Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm
Sat, 23 Jun 2012 09:53:19 +0200
> What is exactly the problem?
> Peter's got an ARM specific KVM device he wants to stick in hw/kvm.
Can't it go in hw/arm/kvm (mimicking the final desired place, which
will be target-arm/hw/kvm)? And hw/kvm can be moved to hw/i386/kvm, or
we can leave it there for now until we're ready to move it to
Anyway, not a big deal since you pointed out another (much better :))
reason to have CONFIG_$ARCH/CONFIG_$BASE_ARCH.
> The way you did it made it possible for hw/arm/Makefile.obj to have a
> different set of objects but also didn't use sub directory makefiles.
Usage of subdirectory makefiles should be treated like a convenience, it isn't
mandatory. You added hw/kvm/Makefile.objs in the patch that fixed
dependency inclusion, hence my confusion. Please try to keep patches
separate for ease of review (especially because you then have separate
commit messages and separate justification for the various bits).
> But in the very short term, CONFIG_I386 makes a good stepping stone to
> CONFIG_PC > and let's use refactor the Makefiles such that we can introduce
> more granular CONFIG_* > down the road without changing object locations.
Indeed, that's a good idea. However, your patch still won't add the
configuration variables to config-all-devices.mak (or it could be a new file
config-all-archs.mak). This is necessary to move files into hw/Makefile.objs
that were in Makefile.target.