[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey |
Date: |
Wed, 27 Jun 2012 06:22:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 06/27/2012 03:59 AM, Amos Kong wrote:
>>> The interface looks like we have settled into something useful that
>>> libvirt can live with. I will leave a more thorough review of the
>>> series to those more familiar with qemu's internals. However, as long
>>> as we are fine-tuning things, I have some questions that might be worth
>>> one more spin:
>>>
>>>> +##
>>>> +# @sendkey:
>>>
>>> Should this be named 'send-key', given that most QMP commands separate
>>> words with '-' rather than squasheverythingtogether?
>>
>> Yes, that's right.
>
> still use sendkey for hmp ?
Libvirt won't care if you rename the hmp command, once the QMP command
is in place. However, for back-compat, since hmp already had 'sendkey',
it probably makes sense to keep that naming instead of gratuitously
changing it, so for now, I'd go with 'send-key' only for QMP.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/6] convert sendkey to qapi, Amos Kong, 2012/06/20
- [Qemu-devel] [PATCH v3 1/6] fix doc of using raw values with sendkey, Amos Kong, 2012/06/20
- [Qemu-devel] [PATCH v3 2/6] monitor: rename keyname '<' to 'less', Amos Kong, 2012/06/20
- [Qemu-devel] [PATCH v3 3/6] hmp: rename arguments, Amos Kong, 2012/06/20
- [Qemu-devel] [PATCH v3 4/6] qapi: generate list struct and visit_list for enum, Amos Kong, 2012/06/20
- [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey, Amos Kong, 2012/06/20
- Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey, Luiz Capitulino, 2012/06/26
[Qemu-devel] [PATCH v3 6/6] ps2: output warning when event queue full, Amos Kong, 2012/06/20