[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving pack

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets
Date: Wed, 27 Jun 2012 16:33:39 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0

On 05/17/2012 08:25 AM, Jason Wang wrote:
> Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible
> crash during initialization of linux driver by checking the operating
> mode.This seems too strict as:
> - the real card could still work in mode other than normal
> - some buggy driver who does not set correct opmode after eeprom
>  access
> So, considering rx ring address were reset to zero (which could be
> safely trated as an address not intened to DMA to), in order to
> both letting old guest work and preventing the unexpected DMA to
> guest, we can forbid packet receiving when rx ring address is zero.

Tested-by: Avi Kivity <address@hidden>

This unbreaks kvm-autotest.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]