[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] bitops.h: Add field32() and field64() functi
Re: [Qemu-devel] [PATCH v2] bitops.h: Add field32() and field64() functions to extract bitfields
Wed, 27 Jun 2012 16:24:12 +0200
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
Avi Kivity <address@hidden> writes:
> On 06/27/2012 04:28 PM, Eric Blake wrote:
>> You marked this function signature as returning uint64_t, but didn't
>> return anything. I think the logical return is the new contents of
>> *pvalue. Another logical choice would be marking the function void.
> Void makes more sense here as you usually want in-place update.
It's an assignment, so I'd follow the precedence of C's assignment
operator and return the new value of the left hand side.
- Re: [Qemu-devel] [PATCH v2] bitops.h: Add field32() and field64() functions to extract bitfields, (continued)