Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

[Alexander Graf]

On 28.06.2012, at 00:05, Benjamin Herrenschmidt wrote:

> On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote:
>> 
>> It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though.
>> Otherwise we'd just silently ignore the option.
> 
> You guys love aborts too much. For a high level option like -vga I'd
> rather just fallback to "std" (like afaik some other machines do in
> unsupported cases) and have something going, maybe with a warning.

If you pass in nothing, yes, default to std. If you explicitly say "I want a 
cirrus adapter", we either give the user a cirrus adapter or we tell him that 
we can't give him what he's asking for. Otherwise what's the point in having 
the option? And if libvirt gets it wrong (again), then we better fix libvirt 
rather than put a hack into QEMU.


Alex