Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: do not blindly memset all read buffers

[Christoph Hellwig]

On Thu, Jun 28, 2012 at 04:06:24PM +0900, MORITA Kazutaka wrote:
> 
> 'offset' is the offset of the sheepdog object.  I think it should be
> 'done' since we need to pass the number of skip bytes.

Indeed.  Odd that mny tests didn't catch this.

> 
> >                  goto done;
> >              }
> > -
> > -            create = 1;
> > -        } else if (acb->aiocb_type == AIOCB_WRITE_UDATA
> > -                   && !is_data_obj_writable(inode, idx)) {
> > -            /* Copy-On-Write */
> > -            create = 1;
> > -            old_oid = oid;
> > -            flags = SD_FLAG_CMD_COW;
> > +            break;
> > +         case AIOCB_WRITE_UDATA:
> 
> Wrong indentation.

Where?  At least I can't find anything obvious and checkpath.pl is fine
with the patch, too.