[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and u
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm |
Date: |
Sun, 01 Jul 2012 16:10:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Il 29/06/2012 14:31, Andreas Färber ha scritto:
>> > Ping? I can't figure out if this discussion got wedged (in which
>> > case, how should it be unwedged?) or if people were eventually happy
>> > with this patch...
> My guess is we're waiting for Paolo to return from vacation and to
> comment. Basically the patch is "correct" but the open issue is how we
> want to structure the directories - do we want hw/kvm/ to contain
> multiple architectures' files, or do we want to separate devices by
> architecture. There's reasons for both once it works technically.
>
> If Anthony split off the kvm/ change it might be less controversial.
I don't really care much about that, I hope it's temporary anyway. :)
However, one change is necessary: the config-all-devices.mak should also
include the arch defines (or if you don't like the naming, we could have
another config-all-arches.mak file). It should not be hard with grep
(perhaps after renaming the variable should probably be named
CONFIG_ARCH_$ARCH). With this change, the patch is perfectly fine!
Paolo