[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface w
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs |
Date: |
Mon, 02 Jul 2012 11:52:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Il 19/06/2012 11:31, Bharata B Rao ha scritto:
>>> > > + ret = pthread_create(&thread, NULL, gluster_handle_poll,
>>> > > + (void *)gctx);
>> >
>> > Please use qemu-thread.h. QEMU uses signals so you almost certainly
>> > want to mask signals for this thread (qemu_thread_create() does that).
> Ok. This is temporary since this entire patch (2/3) would be redundant
> when we have libglusterfsclient working.
Please make sure that libglusterfsclient also masks signals for its own
threads. It's a pretty common source of bugs with threaded libraries,
and masking the signals is harmless for programs that do not care.
Paolo
- Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs,
Paolo Bonzini <=