[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_com
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete |
|
Date: |
Mon, 02 Jul 2012 13:08:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120601 Thunderbird/10.0.5 |
On 06/29/12 18:27, Jan Kiszka wrote:
> Due to queuing/pipelining, there can now be multiple packets per
> endpoint in flight. So the assertion in usb_packet_complete became wrong
> and can cause bogus QEMU terminations. Seen with a passed-through USB
> headset.
NAK. The assert doesn't protect against multiple packets in flight, but
against packet reorderng.
Need to understand why to assert actually triggers.
cheers,
Gerd
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete,
Gerd Hoffmann <=