Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

[Andreas Färber]

Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>> Best to use the same type, to avoid unwanted truncation or sign
>> extension.
>>
>> BlockConf can't use plain int for cyls, heads and secs, because
>> integer properties require an exact width.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  blockdev.h       |    2 +-
>>  hw/hd-geometry.c |    4 ++--
>>  hw/ide/core.c    |    2 +-
>>  hw/scsi-disk.c   |    2 +-
>>  hw/virtio-blk.c  |    2 +-
>>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> It would be nice to update the hd_geometry_lchs_guess() trace event that
> you added to use uint32_t + %u instead of int + %d.

PRIu32?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg