Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Kevin Wolf <address@hidden> writes:
>
>> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>>> New limits straight from ATA4 6.2 Register delivered data transfer
>>> command sector addressing.
>>> 
>>> I figure the old sector limit 63 was blindly copied from the BIOS
>>> int 13 limit.  Doesn't apply to the hardware.  No idea where the old
>>> cylinder limit comes from.
>>> 
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>
>> Now I think we have the very same thing in IDE, SCSI and virtio-blk.
>> Would it make sense to have a helper function in hd-geometry.c that
>> takes and validates the geometry from a BlockConf, applies defaults and
>> puts the result into device state fields passed by reference?
>
> I can look into this, but I'm afraid we'd need two helpers, because of
> IDE complications.

I'd like to try this in a follow-up series, together with a few more
cleanups made possible by this series.  Okay?

[...]