[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match

From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf
Date: Thu, 5 Jul 2012 18:37:21 +0000

On Wed, Jul 4, 2012 at 4:36 PM, Eric Blake <address@hidden> wrote:
> On 07/04/2012 10:19 AM, Paolo Bonzini wrote:
>> Il 03/07/2012 22:15, Andreas Färber ha scritto:
>>>>> I'd also vote for %u. PRI*32 do not seem very useful compared to plain
>>>>> int versions.
>>> If it's not useful we should use unsigned int.
>> It just means that we're assuming 32-bit ints, which is a fact.  The day
>> an IL32 platform appears that has "typedef long int32_t", we'll worry
>> about PRIu32.
> Newlib's <stdint.h> does just that, on platforms that __have_long32.
> Which makes Cygwin a great platform for flushing out these sorts of type
> discrepancies (since cygwin inherits from newlib).
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/newlib/libc/include/stdint.h.diff?r1=1.8&r2=1.9&cvsroot=src&f=h

Interesting, my thoughts went pretty much along Paolo's line. Now I
think PRI*32 indeed makes some sense.

But we don't support Cygwin builds (only mingw), would that be useful?

> --
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]