[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and depos
Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields
Fri, 06 Jul 2012 15:41:39 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0
Am 28.06.2012 14:55, schrieb Peter Maydell:
> Add functions deposit32(), deposit64(), extract32() and extract64()
> to extract and deposit bitfields in 32 and 64 bit words. Based on
> ideas by Jia Liu and Avi Kivity.
> Suggested-by: Jia Liu <address@hidden>
> Suggested-by: Avi Kivity <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> v1->v2: added missing brackets
> v2->v3: renamed field32,field64 to extract32,extract64
> added deposit32,deposit64 at Avi's suggestion
> fixed assertion as per Jay Foad's suggestion
> bikeshed roof is now a slightly darker shade of grey
Reviewed-by: Andreas Färber <address@hidden>
Small improvement would be to replace "Returns the" with "Returns: The"
in line with how you annotated the arguments, and the function summary
should go into its own paragraph between @foo: and Returns:.
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg