[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t |
Date: |
Fri, 06 Jul 2012 15:48:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0 |
Am 05.07.2012 19:00, schrieb Peter Maydell:
> Make the RAM size in arm_boot_info a target_phys_addr_t so
> it can express RAM sizes up to the limit imposed by the
> physical address size.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/arm-misc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm-misc.h b/hw/arm-misc.h
> index 1f96229..c313027 100644
> --- a/hw/arm-misc.h
> +++ b/hw/arm-misc.h
> @@ -25,7 +25,7 @@ qemu_irq *armv7m_init(MemoryRegion *address_space_mem,
>
> /* arm_boot.c */
> struct arm_boot_info {
> - int ram_size;
> + target_phys_addr_t ram_size;
> const char *kernel_filename;
> const char *kernel_cmdline;
> const char *initrd_filename;
Didn't we conclude in lengthy and emotional discussions that int64_t was
the best compromise to solve the highbank and pseries image loading issues?
What I still dislike about target_phys_addr_t is that "ram_size" is not
an address but a size.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity, (continued)
- [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Maydell, 2012/07/05
- Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Crosthwaite, 2012/07/05
- Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Maydell, 2012/07/06
- Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Maydell, 2012/07/06
- Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Maydell, 2012/07/06
- Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Crosthwaite, 2012/07/10
- Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties, Peter Maydell, 2012/07/10