[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN
Date: Sat, 07 Jul 2012 14:22:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0

Il 07/07/2012 09:48, Blue Swirl ha scritto:
>> > I do plan to fix the clarity issue with SCSI data structures and
>> > constants.  But for now, the best compromise is to keep C++ comments
>> > IMHO.  I'm not pushing the responsibility to other people in general,
>> > but if they think C++ comments are a major issue they can send patches.
> When you add them in new code, that is a problem. New code should
> comply with CODING_STYLE,  code with other styles should be converted
> as it is touched.
> It shouldn't be much effort from your part to change the comments in
> this patch to C89 style.

Sure, but that would be the wrong fix.

The right fix is to augment scsi-defs.h, and avoid the need for comments


reply via email to

[Prev in Thread] Current Thread [Next in Thread]