[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool
Date: Mon, 9 Jul 2012 09:14:00 +0100

On 8 July 2012 20:22,  <address@hidden> wrote:
> From: Blue Swirl <address@hidden>
> Use 'bool' type for return value of bit test functions.
> Signed-off-by: Blue Swirl <address@hidden>

I'm 'meh' about the necessity for this change, but it looks safe
and functionally correct to me -- all these functions are either
already returning the result of a comparison, or (in the test_bit
case) a result that's only 0 or 1, so changing the result type
to bool can't break any callers.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]