[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2] ahci: add -drive support
Date: Mon, 09 Jul 2012 13:19:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Alexander Graf <address@hidden> writes:

> On 09.07.2012, at 13:06, Markus Armbruster wrote:
>> Kevin Wolf <address@hidden> writes:
>>> Am 09.07.2012 10:50, schrieb Markus Armbruster:
>>>> Alexander Graf <address@hidden> writes:
>>>>> We've had support for creating AHCI devices using -device for a while now,
>>>>> but it's cumbersome to users. We really should provide an easier way for
>>>>> them to leverage the power of AHCI!
>>>>> So let's introduce a new if= option to -drive, giving users the same
>>>>> command line experience as for scsi or ide.
>>>>> Signed-off-by: Alexander Graf <address@hidden>
>>>>> ---
>>>>> v1 -> v2:
>>>>>  - support more than a single drive per adapter
>>>>>  - support index= option
>>>>>  - treat IF_AHCI the same as IF_IDE
>>>> Inhowfar?  Not obvious to me from the patch, or the diff patch v1.
>>>>>  - add is_ata() helper to match AHCI || IDE
>>>> Not addressed:
>>>> Once we switch to q35, if=ahci will become a redundant wart: to add
>>>> drives to the board's AHCI controller, you'll have to use if=ide.
>>>> if=ahci will create new controllers, which is generally not what you
>>>> want.  Ugh.
>>> Can we even make it the default with q35 as long as our AHCI controller
>>> doesn't also expose a legacy interface for compatibility?
>> Err, what else could we do with if=ide with q35?
> We could create a cmd646 and attach drives to that.

Naive use of the command line then connects your drives to some an old
and slow add-on controller instead of the perfectly servicable and fast
on-board controller.

Let me rephrase my question: s/could/should/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]