[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command
Date: Mon, 09 Jul 2012 14:59:28 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 07/09/2012 12:22 PM, Orit Wasserman wrote:
> Change XBZRLE cache size in bytes (the size should be a power of 2).
> If XBZRLE cache size is too small there will be many cache miss.
> Signed-off-by: Benoit Hudzia <address@hidden>
> Signed-off-by: Petter Svard <address@hidden>
> Signed-off-by: Aidan Shribman <address@hidden>
> Signed-off-by: Orit Wasserman <address@hidden>

> +++ b/qapi-schema.json
> @@ -1390,6 +1390,22 @@
>  { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }

We are copying after bad practice, but...

>  ##
> +# @migrate_set_cachesize

...new QMP commands should prefer '-' over '_'.  While the HMP version
is fine with migrate_set_cachesize, the QMP command should be
migrate-set-cachesize (or even 'migrate-set-cache-size').

> +
> +Set cache size to be used by XBZRLE migration, the cache size will be round 
> down


Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]