[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02
Date: Mon, 09 Jul 2012 18:19:35 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 07/09/2012 06:09 PM, Alexander Graf wrote:

On 09.07.2012, at 18:48, Anthony Liguori wrote:

On 07/02/2012 04:41 AM, Paolo Bonzini wrote:

The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593:

   bsd-user: fix build (2012-06-28 20:28:36 +0000)

Pulled.  Thanks.

Megasas? :)

So this code is really broken:

    info.host.type = MFI_INFO_HOST_PCIX;
    info.device.type = MFI_INFO_DEV_SAS3G;
    info.device.port_count = 2;
    info.device.port_addr[0] = cpu_to_le64(megasas_gen_sas_addr((uint64_t)s));

This will make migration impossible not to mention the fact that casting a pointer to a uint64_t is really broken.

This code needs to be refactored to not do this. It's quite pervasive though (there's a half a dozen instances like this).

I'm going to disable the build by default. I don't want to see a rash fix like (uint64_t)(intptr_t). This needs to be fixed by not making the pointer address guest visible. It can then be re-enabled. Should be easy enough to update your .mak config if you want to test between now and then.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]