[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 08/29] hd-geometry: Factor out guess_chs_for_size
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 08/29] hd-geometry: Factor out guess_chs_for_size() |
Date: |
Tue, 10 Jul 2012 11:12:34 +0200 |
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/hd-geometry.c | 32 ++++++++++++++++++++------------
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index db47846..1a58894 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -97,14 +97,31 @@ static int guess_disk_lchs(BlockDriverState *bs,
return -1;
}
+static void guess_chs_for_size(BlockDriverState *bs,
+ int *pcyls, int *pheads, int *psecs)
+{
+ uint64_t nb_sectors;
+ int cylinders;
+
+ bdrv_get_geometry(bs, &nb_sectors);
+
+ cylinders = nb_sectors / (16 * 63);
+ if (cylinders > 16383) {
+ cylinders = 16383;
+ } else if (cylinders < 2) {
+ cylinders = 2;
+ }
+ *pcyls = cylinders;
+ *pheads = 16;
+ *psecs = 63;
+}
+
void hd_geometry_guess(BlockDriverState *bs,
int *pcyls, int *pheads, int *psecs)
{
int translation, lba_detected = 0;
int cylinders, heads, secs;
- uint64_t nb_sectors;
- bdrv_get_geometry(bs, &nb_sectors);
bdrv_get_geometry_hint(bs, &cylinders, &heads, &secs);
translation = bdrv_get_translation_hint(bs);
@@ -119,16 +136,7 @@ void hd_geometry_guess(BlockDriverState *bs,
if (guess_disk_lchs(bs, &cylinders, &heads, &secs) < 0) {
/* no LCHS guess: use a standard physical disk geometry */
default_geometry:
- cylinders = nb_sectors / (16 * 63);
-
- if (cylinders > 16383) {
- cylinders = 16383;
- } else if (cylinders < 2) {
- cylinders = 2;
- }
- *pcyls = cylinders;
- *pheads = 16;
- *psecs = 63;
+ guess_chs_for_size(bs, pcyls, pheads, psecs);
if ((lba_detected == 1) && (translation == BIOS_ATA_TRANSLATION_AUTO))
{
if ((*pcyls * *pheads) <= 131072) {
bdrv_set_translation_hint(bs,
--
1.7.6.5
- [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 04/29] qtest: Add hard disk geometry test, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 09/29] hd-geometry: Clean up gratuitous goto in hd_geometry_guess(), Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 06/29] hd-geometry: Add tracepoints, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 02/29] vvfat: Fix partition table, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 08/29] hd-geometry: Factor out guess_chs_for_size(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 01/29] fdc: Move floppy geometry guessing back from block.c, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 11/29] hd-geometry: Cut out block layer translation middleman, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 10/29] hd-geometry: Clean up confusing use of prior translation hint, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 03/29] vvfat: Do not clobber the user's geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 07/29] hd-geometry: Unnest conditional in hd_geometry_guess(), Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 14/29] qdev: Introduce block geometry properties, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 15/29] hd-geometry: Switch to uint32_t to match BlockConf, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 12/29] ide pc: Cut out the block layer geometry middleman, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 21/29] qdev: New property type chs-translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 13/29] blockdev: Save geometry in DriveInfo, Markus Armbruster, 2012/07/10