[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access |
|
Date: |
Tue, 10 Jul 2012 12:41:54 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-07-02 11:07, Avi Kivity wrote:
> On 06/29/2012 07:37 PM, Jan Kiszka wrote:
>> Instead of flushing pending coalesced MMIO requests on every vmexit,
>> this provides a mechanism to selectively flush when memory regions
>> related to the coalesced one are accessed. This first of all includes
>> the coalesced region itself but can also applied to other regions, e.g.
>> of the same device, by calling memory_region_set_flush_coalesced.
>
> Looks fine.
>
> I have a hard time deciding whether this should go through the kvm tree
> or memory tree. Anthony, perhaps you can commit it directly to avoid
> the livelock?
>
> Reviewed-by: Avi Kivity <address@hidden>
>
Anthony, ping?
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux