[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types |
Date: |
Tue, 10 Jul 2012 19:18:55 +0000 |
On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster <address@hidden> wrote:
> address@hidden writes:
>
>> From: Blue Swirl <address@hidden>
>>
>> Use 'unsigned int' for bit numbers instead of 'unsigned long' or
>> 'int'. Adjust asserts.
>
> I'd like to lodge a formal objection to this part.
>
> There is no consensus. I recognize the power of maintainers to force a
> change even without consensus. Use it wisely.
I thought I refuted all concrete arguments except performance.
However, Avi kindly provided this part.
- [Qemu-devel] [PATCH v2 0/3] bitops patches, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH v2 1/3] bitops: fix types, blauwirbel, 2012/07/08
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Markus Armbruster, 2012/07/09
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Peter Maydell, 2012/07/10
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Blue Swirl, 2012/07/10
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Peter Maydell, 2012/07/10
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Blue Swirl, 2012/07/12
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Peter Maydell, 2012/07/12
Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Kevin Wolf, 2012/07/11
[Qemu-devel] [PATCH v2 3/3] bitops: use bool, blauwirbel, 2012/07/08