[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2] Add --disable-bridge-helper configure flag

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH V2] Add --disable-bridge-helper configure flag
Date: Wed, 11 Jul 2012 11:12:36 +0100

On 11 July 2012 11:09, Fabien Chouteau <address@hidden> wrote:
> Bridge helper uses ioctl's not available on old Linux versions, we add
> this flag to disable the build.

This is still the wrong approach -- you need to be testing for
presence of the ioctls and disabling the bridge helper if they're
not found. Once you've done that you can, if you like, add
an enable/disable switch with the usual semantics (no switch ==
detect and use if possible, --enable.. == detect and fail configure
if we couldn't build it, --disable == don't build).

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]