qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notificat


From: Eric Blake
Subject: Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists
Date: Wed, 11 Jul 2012 08:59:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote:
> Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method.
> This patch implements a tail queue to store guest notifications for memory
> hot-add and hot-remove requests.
> 
> Guest responses for memory hotplug command on a per-dimm basis can be detected
> with the new hmp command "info memhp" or the new qmp command "query-memhp"
> Examples:
>     

> +++ b/qapi-schema.json
> @@ -1862,3 +1862,29 @@
>  # Since: 0.14.0
>  ##
>  { 'command': 'netdev_del', 'data': {'id': 'str'} }
> +
> +##
> +# @MemHpInfo:
> +#
> +# Information about status of a memory hotplug command
> +#
> +# @Dimm: the Dimm associated with the result
> +#
> +# @result: the result of the hotplug command
> +#
> +# Since: 1.1.3

Should probably be 1.2, not 1.1.3.

> +#
> +##
> +{ 'type': 'MemHpInfo',
> +  'data': {'Dimm': 'str', 'request': 'str', 'result': 'str'} }

Why the upper case?  Wouldn't 'dimm' be more consistent?

> +
> +##
> +# @query-memhp:

Why are we abbreviating?  It might be better to name the QMP command
query-memory-hotplug

> +#
> +# Returns a list of information about pending hotplug commands
> +#
> +# Returns: a list of @MemhpInfo
> +#
> +# Since: 1.1.3

Likewise for 1.2.

> +
> +- "Dimm": Dimm name (json-str)
> +- "request": type of hot request: hot-add or hot-remove  (json-str)
> +- "result": result of the hotplug request for this Dimm success or failure 
> (json-str)

This may need tweaks (such as s/Dimm/dimm/) based on resolution of above
comments.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]