[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

From: Corey Bryant
Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag
Date: Wed, 11 Jul 2012 11:27:26 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 07/11/2012 10:57 AM, Paolo Bonzini wrote:
Il 11/07/2012 16:56, Fabien Chouteau ha scritto:
So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were
inclined to do so...

Unfortunately I don't have time to go deep into the code. It's not a
feature I plan to use, so the quickest solution for me is to disable it.

Corey, I can see that you developed the bridge helper, can you please
take a look at this issue?

Apologies, I was out yesterday.  I see your new patch series is progressing.  
I'll take over if/when you want.

Beside the --enable/--disable patch, there's another question for you.
Is it possible to implement qemu-bridge-adapter without SIOCBRADDIF?

Yes, with the (obsolete) SIOCDEVPRIVATE ioctl.  It has multiple
subcommands, one of which is BRCTL_ADD_IF.


I'll test this out and provide a patch that uses BRCTL_ADD_IF if SIOCBRADDIF is undefined.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]