[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 07/15] target-or32: Add instruction translati
From: |
Jia Liu |
Subject: |
Re: [Qemu-devel] [PATCH v9 07/15] target-or32: Add instruction translation |
Date: |
Fri, 13 Jul 2012 16:26:34 +0800 |
Hi Peter,
On Fri, Jul 13, 2012 at 4:09 PM, Peter Maydell <address@hidden> wrote:
> On 13 July 2012 05:35, Jia Liu <address@hidden> wrote:
>> +static inline uint32_t field(uint32_t val, int start, int length)
>> +{
>> + val >>= start;
>> + val &= ~(~0 << length);
>> + return val;
>> +}
>
> extract32() is in bitops.h now, so it would be better to
> use that instead. Thanks for prodding us to actually write
> this utility routine :-)
I've replace field extract32 after I receive your mail in one minute :-)
Thank you for mind me.
>
> -- PMM
Regards,
Jia
- [Qemu-devel] [PATCH v9 00/15] QEMU OpenRISC support, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 01/15] target-or32: Add target stubs and QOM cpu, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 02/15] target-or32: Add MMU support, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 03/15] target-or32: Add interrupt support, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 04/15] target-or32: Add exception support, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 05/15] target-or32: Add int instruction helpers, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 07/15] target-or32: Add instruction translation, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 08/15] target-or32: Add PIC support, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 09/15] target-or32: Add timer support, Jia Liu, 2012/07/13
- [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Jia Liu, 2012/07/13
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Max Filippov, 2012/07/13
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Jia Liu, 2012/07/14
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Blue Swirl, 2012/07/14
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Jia Liu, 2012/07/14
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Max Filippov, 2012/07/14
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Jia Liu, 2012/07/14
- Re: [Qemu-devel] [PATCH v9 11/15] target-or32: Add system instructions, Blue Swirl, 2012/07/14