[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

From: Mike Frysinger
Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG
Date: Sun, 15 Jul 2012 17:53:42 -0400
User-agent: KMail/1.13.7 (Linux/3.4.4; KDE/4.6.5; x86_64; ; )

On Sunday 15 July 2012 15:54:51 Stefan Weil wrote:
> Am 15.07.2012 22:26, schrieb Mike Frysinger:
> > We should not quote the PKG_CONFIG setting as this deviates from the
> > canonical upstream behavior that gets integrated with all other build
> > systems, and deviates from how we treat all other toolchain variables
> > that we get from the environment.
> > 
> > Ultimately, the point is that it breaks passing custom flags directly
> > to pkg-config via the env var where this normally works elsewhere,
> > and it used to work in the past.
> What about passing custom flags with QEMU_PKG_CONFIG_FLAGS?
> Removing the quotes will not allow paths containing spaces,
> so that's not a good idea.

except that doesn't work with other build variables (like CC/etc...), nor does 
it work with the standard pkg-config build environments.  making qemu deviate 
from the standard to support non-existent setups makes no sense.

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]