|
From: | Pavel Hrdina |
Subject: | Re: [Qemu-devel] [PATCH v2 1/2] fdc: fix relative seek |
Date: | Mon, 16 Jul 2012 15:30:30 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/16/2012 03:26 PM, Pavel Hrdina wrote:
Well, you're right... seek in increase track and seek out decrease track. I suspect that it was correct.On 07/16/2012 03:24 PM, Kevin Wolf wrote:I have host with real floppy device and I could send command directly, so I'll check this behavior.Am 16.07.2012 14:25, schrieb Pavel Hrdina:Signed-off-by: Pavel Hrdina <address@hidden> --- hw/fdc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)I applied both to the block branch for now. This restores the behaviour as it was before 6be01b1e. However, I believe it is still wrong: The direction should be interpreted the other way round, i.e. seek_out should decrease the cylinder number and seek_in should increase it. Do you have a guest that actually uses this command? KevinPavel
I'll send v3 with this fix. Pavel
[Prev in Thread] | Current Thread | [Next in Thread] |