qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] scsi-disk: report resized disk via sense co


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/5] scsi-disk: report resized disk via sense codes
Date: Tue, 17 Jul 2012 13:15:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

Il 17/07/2012 13:14, Kevin Wolf ha scritto:
>> > -    if (s->features & (1 << SCSI_DISK_F_REMOVABLE)) {
>> > -        bdrv_set_dev_ops(s->qdev.conf.bs, &scsi_cd_block_ops, s);
>> > -    }
>> > +    bdrv_set_dev_ops(s->qdev.conf.bs, &scsi_disk_block_ops, s);
> Are you aware of this code?
> 
> bool bdrv_dev_has_removable_media(BlockDriverState *bs)
> {
>     return !bs->dev || (bs->dev_ops && bs->dev_ops->change_media_cb);
> }
> 
> This means that now all SCSI disks have removable media from the
> monitor's point of view.

I remembered there was something similar but I couldn't find it.  I'll
rework the patch to have two separate sets of dev_ops.

Thanks very much!

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]