[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v9 12/27] virtio-blk: Add workaround for BUG_ON()
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [RFC v9 12/27] virtio-blk: Add workaround for BUG_ON() dependency in virtio_ring.h |
|
Date: |
Wed, 18 Jul 2012 22:03:55 +0300 |
On Wed, Jul 18, 2012 at 04:07:39PM +0100, Stefan Hajnoczi wrote:
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/dataplane/vring.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/dataplane/vring.h b/hw/dataplane/vring.h
> index 3eab4b4..44ef4a9 100644
> --- a/hw/dataplane/vring.h
> +++ b/hw/dataplane/vring.h
> @@ -1,6 +1,11 @@
> #ifndef VRING_H
> #define VRING_H
>
> +/* Some virtio_ring.h files use BUG_ON() */
It's a bug then. Do we really need to work around broken systems?
If yes let's just ship our own headers ...
> +#ifndef BUG_ON
> +#define BUG_ON(x)
> +#endif
> +
> #include <linux/virtio_ring.h>
> #include "qemu-common.h"
>
> --
> 1.7.10.4
- [Qemu-devel] [RFC v9 10/27] virtio-blk: Stop data plane thread cleanly, (continued)
[Qemu-devel] [RFC v9 12/27] virtio-blk: Add workaround for BUG_ON() dependency in virtio_ring.h, Stefan Hajnoczi, 2012/07/18
- Re: [Qemu-devel] [RFC v9 12/27] virtio-blk: Add workaround for BUG_ON() dependency in virtio_ring.h,
Michael S. Tsirkin <=
[Qemu-devel] [RFC v9 11/27] virtio-blk: Indirect vring and flush support, Stefan Hajnoczi, 2012/07/18
[Qemu-devel] [RFC v9 14/27] virtio-blk: Use pthreads instead of qemu-thread, Stefan Hajnoczi, 2012/07/18
[Qemu-devel] [RFC v9 16/27] virtio-blk: Kick data plane thread using event notifier set, Stefan Hajnoczi, 2012/07/18
[Qemu-devel] [RFC v9 08/27] virtio-blk: Read requests from the vring, Stefan Hajnoczi, 2012/07/18
[Qemu-devel] [RFC v9 18/27] virtio-blk: Call ioctl() directly instead of irqfd, Stefan Hajnoczi, 2012/07/18