[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types |
|
Date: |
Mon, 23 Jul 2012 18:44:07 +0100 |
On 23 July 2012 18:33, Blue Swirl <address@hidden> wrote:
> I'm getting a strong feeling that it's a bad idea to reuse any Linux
> kernel sources since they are seen as divine and untouchable, unlike
> for example BSD queue macros.
We should also try to avoid deviations in our queue macros,
and I think we do (eg commit 6095aa8 added functionality by
moving us closer into sync with the BSD macros rather than
by reinventing the wheel which was IIRC what the initial pre-code-review
patch did).
-- PMM