[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm |
Date: |
Tue, 24 Jul 2012 14:04:22 -0300 |
On Thu, 12 Jul 2012 11:56:28 -0600
Eric Blake <address@hidden> wrote:
> On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <address@hidden>
> > ---
>
> > +++ b/qapi-schema.json
> > @@ -1889,4 +1889,26 @@
> > #
> > # Since: 1.2
> > ##
> > -{ 'command': 'savevm', 'data': {'*name': 'str'} }
> > \ No newline at end of file
> > +{ 'command': 'savevm', 'data': {'*name': 'str'} }
> > +
> > +##
> > +# @loadvm:
>
> Similar to my question in 1/4, should this be named 'load-vm'?
Yes.
>
> > +#
> > +# Set the whole virtual machine to the snapshot identified by the tag
> > +# 'tag' or the unique snapshot ID 'id'.
> > +#
> > +# @name: tag or id of existing snapshot
> > +#
> > +# Returns: Nothing on success
> > +# If no block device can accept snapshots, SnapshotNotAccepted
> > +# If no snapshot is found, SnapshotNotFound
> > +# If snapshot is only disk snapshot, SnapshotInvalid
> > +# If there is a writable device not supporting snapshots,
> > +# SnapshotNotSupported
> > +# If snapshot activate failed, SnapshotActivateFailed
> > +# If open a block device for vm state fail, SnapshotOpenFailed
> > +# If an error occures while loading vm state, SnapshotLoadFailed
>
> s/occures/occurs/
>
- [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm, (continued)
[Qemu-devel] [RFC PATCH 4/4] qapi: Convert info snapshots, Pavel Hrdina, 2012/07/12
[Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm, Pavel Hrdina, 2012/07/12
Re: [Qemu-devel] [RFC PATCH 0/4] qapi: Convert snapshot's commands, Luiz Capitulino, 2012/07/24