[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types

From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types
Date: Tue, 24 Jul 2012 19:51:36 +0000

On Tue, Jul 24, 2012 at 9:26 AM, Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>> On 23 July 2012 18:33, Blue Swirl <address@hidden> wrote:
>>> I'm getting a strong feeling that it's a bad idea to reuse any Linux
>>> kernel sources since they are seen as divine and untouchable, unlike
>>> for example BSD queue macros.
> Reusing good code that solves the problem at hand can be a bad idea if
> you can't resist the temptation to tinker with it, yet can't be bothered
> to upstream your improvements.  Then you might as well build your own
> bikeshed from scratch :)

There's nothing wrong in tinkering with reused good code. As I
explained, there's little point to upstream these changes, so 'not
bothering' is false accusation.

>> We should also try to avoid deviations in our queue macros,
> Agree.

Avoiding "deviations" can be secondary to many other needs.

>> and I think we do (eg commit 6095aa8 added functionality by
>> moving us closer into sync with the BSD macros rather than
>> by reinventing the wheel which was IIRC what the initial pre-code-review
>> patch did).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]