[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies irqfds |
Date: |
Wed, 25 Jul 2012 17:54:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-07-25 17:52, Peter Maydell wrote:
> On 25 July 2012 16:47, Jan Kiszka <address@hidden> wrote:
>> On 2012-07-25 15:24, Peter Maydell wrote:
>>> --- a/kvm-all.c
>>> +++ b/kvm-all.c
>>> @@ -101,6 +101,7 @@ struct KVMState
>>> KVMState *kvm_state;
>>> bool kvm_kernel_irqchip;
>>> bool kvm_async_interrupt_injection;
>>> +bool kvm_irqfds_allowed;
>>
>> Why allowed vs enabled? You only have kvm_async_interrupt_injection as well.
>
> I was trying to follow the existing pattern where the macro kvm_enabled()
> tests the variable kvm_allowed (though as you noticed I got it wrong for
> kvm_async_interrupt_injection: will fix that in v2.)
>
> Having the two the same is valid C, it's just a style question whether
> having a variable foo and a macro foo() is considered confusing I guess.
I don't mind which way if they are consistent.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, (continued)
[Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel(), Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 5/6] kvm: Don't assume irqchip implies MSI routing via irqfds, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies irqfds, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 3/6] kvm: Move kvm_allows_irq0_override() to target-i386, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 1/6] kvm: Decouple 'interrupt injection is async' from 'kernel irqchip', Peter Maydell, 2012/07/25