Re: [Qemu-devel] [PATCH V3 2/3] block: Use bdrv_get_backing_file_ancestors_count()

[Benoît Canet]

Le Wednesday 25 Jul 2012 à 10:37:53 (-0600), Eric Blake a écrit :
> On 07/25/2012 06:36 AM, address@hidden wrote:
> > From: Benoît Canet <address@hidden>
> > 
> > Use the dedicated counting function in qmp_query_block in order to
> > propagate the backing file count to HMP.
> > 
> > Signed-off-by: Benoit Canet <address@hidden>
> 
> > +++ b/qapi-schema.json
> > @@ -398,6 +398,8 @@
> >  #
> >  # @backing_file: #optional the name of the backing file (for copy-on-write)
> >  #
> > +# @backing_file_ancestors_count: #the count of ancestors backing files 
> > (since: 1.2)
> 
> s/ancestors/ancestor's/ ?
> 
> s/#//
> 
> You are making it sound like this is the count of ancestors of the
> backing file (that is, 'base <- sn1 <- sn2' would have a count of 1,
> since there is 1 ancestor of the backing file sn1; and what if I have no
> backing file?), rather than a count of ancestors of this file (base has
> a count of 0, base <- sn1 has a count of 1).  Maybe a better wording is:
> 
> @backing_file_depth: number of files in the backing file chain (since: 1.2)

I'll change it

Benoît

> 
> -- 
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>