[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy refcoun
Re: [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test
Wed, 25 Jul 2012 11:54:50 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
On 07/25/2012 06:21 AM, Stefan Hajnoczi wrote:
> This tests establishes the basic post-conditions of the qcow2 lazy
> refcounts features:
> 1. If the image was closed normally, it is marked clean.
> 2. If an allocating write was performed and the image was not close
> normally, then it is marked dirty.
> a. Written data can be read back successfully.
> b. The image file can be repaired and will be marked clean again.
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> +++ b/tests/qemu-iotests/039
> @@ -0,0 +1,117 @@
Since you are assuming bash (and even if you were to assume POSIX
> +seq=`basename $0`
I prefer $() over ``.
> +echo "QA output created by $seq"
POSIX (and therefore bash) guarantees that $PWD is sane, and faster to
access than $(pwd).
That's not very secure. It may be worth using bash's $RANDOM, or using
Beyond that, the series seemed reasonable to me.
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 2/7] qcow2: introduce dirty bit, Stefan Hajnoczi, 2012/07/25
[Qemu-devel] [PATCH v2 4/7] qemu-iotests: ignore qemu-img create lazy_refcounts output, Stefan Hajnoczi, 2012/07/25
[Qemu-devel] [PATCH v2 6/7] qemu-io: add "abort" command to simulate program crash, Stefan Hajnoczi, 2012/07/25
[Qemu-devel] [PATCH v2 1/7] docs: add dirty bit to qcow2 specification, Stefan Hajnoczi, 2012/07/25