[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey
Date: Thu, 26 Jul 2012 15:22:25 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

On 07/25/2012 10:49 PM, Amos Kong wrote:
> Convert 'sendkey' to use QAPI.
> Keys' indexes in the enmu are same as keycodes' indexes in the


> key_defs[], index_from_code() and index_from_key() will return
> Q_KEY_CODE_MAX if the code/key is invalid.
> For qmp, QAPI would check invalid key and raise error.
> For hmp, invalid key is checked in hmp_send_key().
> 'send-key' of QMP doesn't support key in hexadecimal format.
> Signed-off-by: Amos Kong <address@hidden>

I glanced through the series, and didn't see anything else suspicious
from my point of view.  The QMP interface which libvirt will be using
appears to be sane.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]