Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

[Blue Swirl]

On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell
<address@hidden> wrote:
> On 28 July 2012 10:04, Blue Swirl <address@hidden> wrote:
>> On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell <address@hidden> wrote:
>>> +    echo "ERROR: configure test passed without -Werror but failed with 
>>> -Werror."
>>> +    echo "This is probably a bug in the configure script. The failing 
>>> command"
>>> +    echo "will be at the bottom of config.log."
>>> +    echo "You can run configure with --disable-werror to bypass this 
>>> check."
>>> +    exit 1
>>
>> This should be degraded to a warning
>
> The idea is that by running configure with --enable-werror (either
> explicitly or implicitly for a git build) you've asked for compile
> warnings to cause build failure. We're just doing that in configure
> as well as for the main build.
>
>>, I'm getting configure breakage
>> in some cases:
>
> The thesis of the patch series is that these represent bugs to be fixed.

Yes, but then the errors should be fixed by the series. When adding
new GCC warning flags, I also fixed the causes for the warning first.
Committing known build breakages is not OK.

>
> -- PMM