[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display ho

From: Supriya Kannery
Subject: Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting
Date: Sun, 29 Jul 2012 11:51:50 +0530
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110817 Fedora/3.1.12-1.fc14 Thunderbird/3.1.12

On 07/11/2012 07:33 PM, Luiz Capitulino wrote:
On Mon, 09 Jul 2012 16:43:40 +0200
Kevin Wolf<address@hidden>  wrote:

Am 15.06.2012 23:07, schrieb Eric Blake:
On 06/15/2012 02:47 PM, Supriya Kannery wrote:
Enhance "info block" to display hostcache setting for each
block device.

  { 'type': 'BlockInfo',
    'data': {'device': 'str', 'type': 'str', 'removable': 'bool',
-           'locked': 'bool', '*inserted': 'BlockDeviceInfo',
+           'locked': 'bool','hostcache': 'bool', '*inserted': 

space after comma

Since 'hostcache' was not present when talking to older qemu, should we
mark it optional?

What does "optional" really mean? I always understood that it means that
whether the field exists or not depends on some runtime condition, not
on the qemu version. I would specify something like this, that always
exists in new qemu versions, in the "Since" section. Or maybe a separate
"Since" specification like in SpiceInfo for mouse-mode.

Yes, Kevin is right.

Will add a comment " Since: 1.x"

-thanks, Supriya

reply via email to

[Prev in Thread] Current Thread [Next in Thread]