[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/18] qom: release previous object when setting
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 10/18] qom: release previous object when setting |
Date: |
Mon, 30 Jul 2012 15:51:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
Am 19.07.2012 20:53, schrieb address@hidden:
> From: Corey Minyard <address@hidden>
>
> When setting an object, if you don't release the previous object
> that was there, it may become unusable. This change allows a
> chardev to be removed from one object's properties and added to
> another's.
>
> Signed-off-by: Corey Minyard <address@hidden>
> Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Anthony, this looks like a valid and generic QOM memory leak fix to me.
Suggesting to cherry-pick this patch to master and stable-1.1.
Andreas
> ---
> qom/object.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index 00bb3b0..f0ff9cc 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -731,6 +731,9 @@ void object_property_set(Object *obj, Visitor *v, const
> char *name,
> if (!prop->set) {
> error_set(errp, QERR_PERMISSION_DENIED);
> } else {
> + if (prop->release) {
> + prop->release(obj, name, prop->opaque);
> + }
> prop->set(obj, v, prop->opaque, name, errp);
> }
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] Third shot at adding IPMI to qemu, minyard, 2012/07/19
- [Qemu-devel] [PATCH 06/18] qemu-char: Fix a race reporting opens and closes, minyard, 2012/07/19
- [Qemu-devel] [PATCH 10/18] qom: release previous object when setting, minyard, 2012/07/19
- Re: [Qemu-devel] [PATCH 10/18] qom: release previous object when setting,
Andreas Färber <=
- [Qemu-devel] [PATCH 04/18] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts, minyard, 2012/07/19
- [Qemu-devel] [PATCH 09/18] qdev: Add a pre-firmware init capability, minyard, 2012/07/19
- [Qemu-devel] [PATCH 07/18] qemu-char: remove free of chr from win_stdio_close, minyard, 2012/07/19
- [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry, minyard, 2012/07/19