Re: [Qemu-devel] [PATCHv2] qemu: add .exrc

[Blue Swirl]

On Sun, Jul 29, 2012 at 2:08 PM, Michael S. Tsirkin <address@hidden> wrote:
> On Thu, Jul 19, 2012 at 05:48:32PM +0300, Michael S. Tsirkin wrote:
>> I've been using this to get correct indenting with vim
>> in qemu for a while, but it's a bit easier if we
>> put the settings in the central place.
>> Note that
>> 1. you still need to enable 'exrc' and 'secure'
>>    options in your vimrc for these settings to take effect.
>> 2. you can create a .vimrc file if 'exrc' is on but there's
>>    need to bypass this configuration.
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> So two -1 and one +1, given +1 seems to be the only one from a vim user
> I'm inclined to go ahead with this one as others aren't likely to be
> negatively affected...
>
>> ---
>>
>> Changes from v1:
>>     added some comments explaining usage
>>
>>  .exrc | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>  create mode 100644 .exrc
>>
>> diff --git a/.exrc b/.exrc
>> new file mode 100644
>> index 0000000..37755ed
>> --- /dev/null
>> +++ b/.exrc
>> @@ -0,0 +1,7 @@
>> +"VIM settings to match QEMU coding style.  They are activated by adding the
>> +"following settings (without the " symbol) as last two lines in 
>> $HOME/.vimrc:
>> +"set secure
>> +"set exrc

Doesn't this make VIM to read commands from all files edited, not just
files of QEMU? Aren't there security implications from this
recommendation?

>> +set expandtab
>> +set shiftwidth=4
>> +set smarttab
>> --
>> MST
>