[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities |
Date: |
Mon, 30 Jul 2012 11:45:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 07/29/2012 03:42 AM, Orit Wasserman wrote:
> Add migration capabilities that can be queried by the management.
> The management can query the source QEMU and the destination QEMU in order to
> verify both support some migration capability (currently only XBZRLE).
>
> Signed-off-by: Orit Wasserman <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
> +++ b/qapi-schema.json
> @@ -306,6 +306,45 @@
> { 'command': 'query-migrate', 'returns': 'MigrationInfo' }
>
> ##
> +# @MigrationCapability
> +#
> +# Migration capabilities enumeration
> +#
> +# @xbzrle: Migration supports xbzrle (Xor Based Zero Length Encoding).
In patch 3/10, you named it:
XBZRLE (Xor Based Zero Run Length Encoding)
You are missing 'Run' here.
> +# This feature allows us to minimize migration traffic for certain
> work
> +# loads, by sending compressed difference of the pages
> +#
> +# Since: 1.2
We are inconsistent on whether this should be 'Since: 1.2.0' or 'Since:
1.2', but cleaning that up would be an independent patch since there are
pre-existing uses of both forms.
Other than that,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature