[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migra
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters |
Date: |
Mon, 30 Jul 2012 15:04:57 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Luiz Capitulino <address@hidden> writes:
> On Mon, 30 Jul 2012 14:45:04 -0500
> Anthony Liguori <address@hidden> wrote:
>
>> Orit Wasserman <address@hidden> writes:
>>
>> > The management can enable/disable a capability for the next migration by
>> > using
>> > migrate_set_parameter command.
>> > The management can query the current migration capabilities using
>> > query-migrate-parameters
>> >
>> > Signed-off-by: Orit Wasserman <address@hidden>
>> > Signed-off-by: Juan Quintela <address@hidden>
>>
>> We have a way to add new commands. Let's not invent a new one.
>> Otherwise every subsystem would have it's own approach to querying
>> what's available.
>
> I think it does make sense for setting/getting migration's capabilities, which
> are just booleans. And that's what the commands currently do, btw.
>
> I'd only recommend to rename them to migrate_set_capability
> query-migrate-capabilities.
If that's the intent, it should take/return a list of capabilities
(expressed as an enum).
Regards,
Anthony Liguori
- Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters, (continued)
[Qemu-devel] [PATCH 03/11] Add XBZRLE documentation, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 05/11] Add uleb encoding/decoding functions, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 04/11] Add cache handling functions, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 07/11] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages, Orit Wasserman, 2012/07/29